Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rollup #2109

Merged
merged 3 commits into from
Jul 16, 2023
Merged

chore: update rollup #2109

merged 3 commits into from
Jul 16, 2023

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Jun 30, 2023 •
edited
Loading

Continues from PR

Part of

Summary

Update rollup and plugins, and remove some plugins. We'll use Rollup for now only to bundle and minify our code, but otherwise we'll write reasonably modern code and not need a transform.

What kind of change does this PR introduce?

Build-related changes

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

This is part of Simplify and modernize Docsify

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 5:11pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cb7602:

Sandbox Source
docsify-template Configuration

@trusktr
chore: update rollup
7a972d4 
Update rollup and plugins, and remove some plugins. We'll use Rollup for
now only to bundle and minify our code, but otherwise we'll write
reasonably modern code and not need a transform.
@trusktr
Merge branch 'es-modules' into update-rollup
9cb7602 
* es-modules:
  feat: add google analytics gtag.js plugin (#1702)
  chore: bump conventional-changelog-cli from 2.2.2 to 3.0.0 (#2085)
@trusktr trusktr marked this pull request as ready for review July 2, 2023 20:09
This was referenced Jul 2, 2023
Closed
Merged
Koooooo-7
Koooooo-7 previously approved these changes Jul 6, 2023
View reviewed changes
Base automatically changed from es-modules to develop July 16, 2023 17:06
@trusktr trusktr dismissed Koooooo-7’s stale review July 16, 2023 17:06

The base branch was changed.

@trusktr trusktr enabled auto-merge July 16, 2023 17:16
@trusktr trusktr disabled auto-merge July 16, 2023 17:16
@trusktr trusktr merged commit 4d560c0 into develop Jul 16, 2023
@trusktr trusktr deleted the update-rollup branch July 16, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koooooo-7 Koooooo-7 Koooooo-7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trusktr @Koooooo-7