Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant dependabot PR #173

Closed
wants to merge 1 commit into from
Closed

Variant dependabot PR #173

wants to merge 1 commit into from

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jul 18, 2024

Description
Variant of dependabot PR #146. I don't think there's a way to tweak the dependabot branch directly, so I just created a new branch.

Updating the jackson-version property did not work, as some of the other artifacts using that property do no exist for that version.

Issue
None

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.

@denis-yuen
Copy link
Member

I don't think there's a way to tweak the dependabot branch directly, so I just created a new branch.

They are branches, not forks. You should be able to push to them normally

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a code comment.
Sometimes the versions will resync later and we should watch for it otherwise you could get conflicting dependencies.

@coverbeck
Copy link
Contributor Author

I don't think there's a way to tweak the dependabot branch directly, so I just created a new branch.

They are branches, not forks. You should be able to push to them normally

D'oh! I'm just going to tweak that one instead and close this one.

@coverbeck coverbeck closed this Jul 18, 2024
@coverbeck coverbeck deleted the feature/pseudodependabot branch July 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants