Upgrade Cloudwatch to Slack Lambda for Node 18 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEAB-5759 The Node18 lambda environment includes AWS SDK v3; Node14 had v2. Also got rid of unused files that confused me when trying to update this lambda.
svonworl
approved these changes
Jul 27, 2023
kathy-t
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally the code running on Node 14 would just continue to work, but the AWS Node 18 lambda environment includes AWS SDK v3; the AWS Node 14 has v2. So I upgraded the code to use the newer AWS SDK, as well as refactoring the code a little bit.
I also got rid of unused files that confused me when trying to update this lambda.
This will only work with the companion PR in dockstore-deploy, as that is where the runtime environment for the lambdas is specified.
Issue
SEAB-5759
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!