Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ai tooltip #2036

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

david4096
Copy link
Member

@david4096 david4096 commented Oct 24, 2024

Description

AI tooltip in search just repeats what's already there.

image

Review Instructions

Search results appear as normal without a tooltip.

Issue

N/a

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@david4096 david4096 changed the base branch from develop to release/2.13.0-beta.1 October 24, 2024 16:38
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.66%. Comparing base (cafff65) to head (b483f01).
Report is 1 commits behind head on release/2.13.0-beta.1.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/2.13.0-beta.1    #2036   +/-   ##
======================================================
  Coverage                  41.66%   41.66%           
======================================================
  Files                        394      394           
  Lines                      12318    12318           
  Branches                    2959     2959           
======================================================
  Hits                        5132     5132           
  Misses                      4861     4861           
  Partials                    2325     2325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl
Copy link
Contributor

Needs the same change in the "tool" and "notebook" search result templates.

@david4096
Copy link
Member Author

Needs the same change in the "tool" and "notebook" search result templates.

Fixed thanks @svonworl

Copy link

sonarcloud bot commented Oct 24, 2024

@david4096 david4096 merged commit d7fa51d into release/2.13.0-beta.1 Oct 24, 2024
18 of 19 checks passed
@david4096 david4096 deleted the feature/remove-ai-tooltip branch October 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants