Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dompurify and ngx-markdown #2032

Open
wants to merge 3 commits into
base: release/2.13.0-beta.1
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2024

Bumps dompurify to 2.5.4 and updates ancestor dependency ngx-markdown. These dependencies need to be updated together.

Updates dompurify from 2.4.1 to 2.5.4

Release notes

Sourced from dompurify's releases.

DOMPurify 2.5.4

  • Fixed a bug with latest isNaN checks affecting MSIE, thanks @​tulach
  • Fixed the tests for MSIE and fixed related test-runner

DOMPurify 2.5.3

  • Fixed several mXSS variations found by and thanks to @​kevin-mizu & @​Ry0taK
  • Added better configurability for comment scrubbing default behavior
  • Added better hardening against Prototype Pollution attacks, thanks @​kevin-mizu
  • Fixed some smaller issues in README and other documentation

DOMPurify 2.5.2

  • Addressed and fixed a mXSS variation found by @​kevin-mizu
  • Addressed and fixed a mXSS variation found by Adam Kues of Assetnote
  • Updated tests for older Safari and Chrome versions

DOMPurify 2.5.1

  • Fixed an mXSS sanitizer bypass reported by @​icesfont
  • Added new code to track element nesting depth
  • Added new code to enforce a maximum nesting depth of 255
  • Added coverage tests and necessary clobbering protections

Note that this is a security release and should be upgraded to immediately. Please also note that further releases may follow as the underlying vulnerability is apparently new and further variations may be discovered.

DOMPurify 2.5.0

  • Added new setting SAFE_FOR_XML to enable better control over comment scrubbing
  • Updated the LICENSE file to show the accurate year number
  • Updated several build and test dependencies

DOMPurify 2.4.9

  • Fixed another conditional bypass caused by Processing Instructions, thanks @​Ry0taK
  • Fixed the regex for HTML Custom Element detection, thanks @​AlekseySolovey3T

DOMPurify 2.4.8

  • Fixed two possible bypasses when sanitizing an XML document and later using it in HTML, thanks @​Slonser

DOMPurify 2.4.7

DOMPurify 2.4.6

  • Fixed a bypass in jsdom 22 in case the noframes element is permitted, thanks @​leeN

DOMPurify 2.4.5

  • Fixed a problem with improper reset of custom HTML options, thanks @​ammaraskar

DOMPurify 2.4.4

DOMPurify 2.4.3

  • Final release that is compatible with MSIE10 & MSIE 11

... (truncated)

Commits
  • 10c1261 docs: Updated README ever so slightly
  • 1c92880 test: Fixed two more tests for MSIE11 and Edge 18
  • 1401208 test: Fixed more tests for MSIE and Edge 18
  • 2c6410a test: Fixed several new tests for MSIE11 and Edge 18
  • 2c9bca9 test: Changed github config to include MSIE tests for 2.x
  • b188787 chore: Preparing 2.5.4 release
  • 707b3d6 fix: Added a better for for the MSIE iNaN issue
  • 62fe3be test: Attempting to get MSIE 11 back into the browser test array
  • f3a9710 fix: Fixed an issue with MSIE and no support for Number.isNaN
  • e1ddfc7 Merge branch '2.x' of github.com:cure53/DOMPurify into 2.x
  • Additional commits viewable in compare view

Updates ngx-markdown from 16.0.0 to 18.1.0

Release notes

Sourced from ngx-markdown's releases.

v18.1.0

New features and enhancements

Bug Fixes

Special Thanks

🥇 Thanks to @​klofi for his contribution in fixing globally imported CLIPBOARD_OPTIONS 🥇 Thanks to @​hardikpatel043 for his contribution in adding support for mermaid 11.0.0

v18.0.0

Update Angular 18

Library has been updated to support Angular 18.

It is recommended to stick with ngx-markdown v17.x.x if you are using Angular 17.

New features and enhancements

  • Update to Angular 18
  • Remove clipboard button inline opacity transition and add CSS classes

⚠️ Breaking changes

Clipboard Plugin

The clipboard button no longer has an opacity transition by default. Instead, CSS classes have been added to allow customization as documented in the README.md and the Plugins > Clipboard Plugin section of the demo site.

To keep the previous behavior, simply add the following CSS to your global styles.css/scss styling file.

.markdown-clipboard-toolbar {
  opacity: 0;
  transition: opacity 250ms ease-out;
}
.markdown-clipboard-toolbar.hover {
opacity: 1;
}

Special thanks

🥇 Thanks to @​pkurcx for his contribution to update Angular 18.

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

svonworl and others added 2 commits October 15, 2024 08:57
Bumps [dompurify](https://github.com/cure53/DOMPurify) to 2.5.4 and updates ancestor dependency [ngx-markdown](https://github.com/jfcere/ngx-markdown). These dependencies need to be updated together.


Updates `dompurify` from 2.4.1 to 2.5.4
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.4.1...2.5.4)

Updates `ngx-markdown` from 16.0.0 to 18.1.0
- [Release notes](https://github.com/jfcere/ngx-markdown/releases)
- [Commits](jfcere/ngx-markdown@v16.0.0...v18.1.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: indirect
- dependency-name: ngx-markdown
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 22, 2024
@dependabot dependabot bot requested review from a team, david4096, hyunnaye and svonworl and removed request for a team October 22, 2024 17:27
@david4096 david4096 changed the base branch from develop to release/2.13.0-beta.1 October 22, 2024 21:37
@david4096
Copy link
Member

Changed the target branch to point at release

Copy link
Contributor

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't build for me locally. The ngx-markdown major version, 18, needs to match the Angular major version, which we currently have at 16.

I think we have to wait on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants