-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCK-2533-followup: Fix regex in Register Workflow dialog #2028
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2028 +/- ##
========================================
Coverage 41.67% 41.67%
========================================
Files 394 394
Lines 12315 12315
Branches 2959 2959
========================================
Hits 5132 5132
- Misses 4858 4859 +1
+ Partials 2325 2324 -1 ☔ View full report in Codecov by Sentry. |
@@ -7,7 +7,7 @@ export const extendedGalaxy: ExtendedDescriptorLanguageBean = { | |||
shortFriendlyName: 'Galaxy', | |||
friendlyName: 'Galaxy Workflow Format', | |||
defaultDescriptorPath: '/workflow-name.yml', | |||
descriptorPathPattern: '^/([^/?:*|<>]+/)*[^/?:*|<>]+.(ga|yaml|yml)', | |||
descriptorPathPattern: '^\\/([^\\/?:*\\|<>]+\\/)*[^\\/?:*\\|<>]+.(ga|yaml|yml)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change, and it was like this, but except for Snakemake, the bulk of the pattern, except the file extension part, is the same 5 times. If you had a constant somewhere, you'd only have to change it once.
Quality Gate passedIssues Measures |
Description
This PR fixes the regex issues found in the "Register workflow" dialog.
Similar to this PR, this error was only shown on the FireFox console due to the v-mode flag.
Review Instructions
Editing the Workflow Path in the Register Workflow dialog (Register custom remote workflows option) should not show any
Unable to check input pattern
errors.Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2533
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities