Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCK-2533-followup: Fix regex in Register Workflow dialog #2028

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Oct 7, 2024

Description
This PR fixes the regex issues found in the "Register workflow" dialog.
Similar to this PR, this error was only shown on the FireFox console due to the v-mode flag.

Review Instructions
Editing the Workflow Path in the Register Workflow dialog (Register custom remote workflows option) should not show any Unable to check input pattern errors.

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2533

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Oct 7, 2024
@hyunnaye hyunnaye marked this pull request as ready for review October 7, 2024 21:54
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.67%. Comparing base (b88e89e) to head (b1f2324).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2028   +/-   ##
========================================
  Coverage    41.67%   41.67%           
========================================
  Files          394      394           
  Lines        12315    12315           
  Branches      2959     2959           
========================================
  Hits          5132     5132           
- Misses        4858     4859    +1     
+ Partials      2325     2324    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -7,7 +7,7 @@ export const extendedGalaxy: ExtendedDescriptorLanguageBean = {
shortFriendlyName: 'Galaxy',
friendlyName: 'Galaxy Workflow Format',
defaultDescriptorPath: '/workflow-name.yml',
descriptorPathPattern: '^/([^/?:*|<>]+/)*[^/?:*|<>]+.(ga|yaml|yml)',
descriptorPathPattern: '^\\/([^\\/?:*\\|<>]+\\/)*[^\\/?:*\\|<>]+.(ga|yaml|yml)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change, and it was like this, but except for Snakemake, the bulk of the pattern, except the file extension part, is the same 5 times. If you had a constant somewhere, you'd only have to change it once.

src/app/descriptor-languages/Galaxy.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 8, 2024

@hyunnaye hyunnaye merged commit 88a2a0f into develop Oct 8, 2024
19 checks passed
@hyunnaye hyunnaye deleted the feature/DOCK-2533-followup branch October 8, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants