ability to cancel label changes (#308)

dockstore · Jun 18, 2018 · 0b2e382 · 0b2e382
1 parent c0e8edd
commit 0b2e382
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 2 deletions.
diff --git a/src/app/container/container.component.html b/src/app/container/container.component.html
@@ -121,6 +121,9 @@ <h3>
                  (matChipInputTokenEnd)="addToLabels($event)"/>
         </mat-chip-list>
       </mat-form-field>
+      <button type="button"(click)="cancelLabelChanges()" class="btn btn-link" *ngIf="labelsEditMode && !isToolPublic">
+         <span class="glyphicon glyphicon-remove"></span> Cancel
+      </button>
       <button type="button"(click)="submitContainerEdits()" class="btn btn-link" *ngIf="labelsEditMode && !isToolPublic">
         <span class="glyphicon glyphicon-floppy-save"></span>Save
       </button>

diff --git a/src/app/container/container.component.ts b/src/app/container/container.component.ts
@@ -267,6 +267,11 @@ export class ContainerComponent extends Entry {
       });
   }
 
+  cancelLabelChanges(): void {
+    this.containerEditData.labels = this.dockstoreService.getLabelStrings(this.tool.labels);
+    this.labelsEditMode = false;
+  }
+
   public toolCopyBtnClick(copyBtn): void {
     this.containerService.setCopyBtn(copyBtn);
   }

diff --git a/src/app/shared/entry.ts b/src/app/shared/entry.ts
@@ -391,4 +391,9 @@ export abstract class Entry implements OnInit, OnDestroy, AfterViewInit {
    * @param  label label to remove
    */
   abstract removeLabel(label: any): void;
+
+  /**
+   * Cancels any unsaved label changes
+   */
+  abstract cancelLabelChanges(): void;
 }
diff --git a/src/app/workflow/workflow.component.html b/src/app/workflow/workflow.component.html
@@ -90,7 +90,7 @@ <h3>
   <div *ngIf="workflow" class="col-sm-12" style="margin-bottom: 5px;">
     <span *ngIf="!labelsEditMode">
       <mat-chip-list>
-        <mat-chip color="primary" *ngFor="let label of workflowEditData.labels" (click)="goToSearch(label)">{{label}}</mat-chip>
+        <mat-chip color="primary" *ngFor="let label of workflowEditData" (click)="goToSearch(label)">{{label}}</mat-chip>
         <button type="button" *ngIf="!labelsEditMode && !isWorkflowPublic" class="btn btn-link" (click)="toggleLabelsEditMode()">
           Manage labels
         </button>
@@ -112,8 +112,11 @@ <h3>
                  (matChipInputTokenEnd)="addToLabels($event)"/>
         </mat-chip-list>
       </mat-form-field>
+      <button type="button"(click)="cancelLabelChanges()" class="btn btn-link" *ngIf="labelsEditMode && !isWorkflowPublic">
+        <span class="glyphicon glyphicon-remove"></span> Cancel
+      </button>
       <button type="button"(click)="submitWorkflowEdits()" class="btn btn-link" *ngIf="labelsEditMode && !isWorkflowPublic">
-        <span class="glyphicon glyphicon-floppy-save"></span>Save
+        <span class="glyphicon glyphicon-floppy-save"></span> Save
       </button>
     </span>
   </div>

diff --git a/src/app/workflow/workflow.component.ts b/src/app/workflow/workflow.component.ts
@@ -252,6 +252,12 @@ export class WorkflowComponent extends Entry {
       this.setWorkflowLabels();
     }
   }
+
+  cancelLabelChanges(): void {
+    this.workflowEditData.labels = this.dockstoreService.getLabelStrings(this.workflow.labels);
+    this.labelsEditMode = false;
+  }
+
   setWorkflowLabels(): any {
     return this.workflowsService.updateLabels(this.workflow.id, this.workflowEditData.labels.join(', '))
       .subscribe(workflow => {