Remove references to forceRevocationCheck #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Hellawell <[email protected]>
cykoder
force-pushed
the
cleanup/force-revocation-check
branch
from
5a635fc
to
2784147
Compare
lovesh
reviewed
Oct 6, 2023
| @@ -106,8 +106,6 @@ export async function verifyPresentationCredentials( | |||
| * @property {DIDResolver} [resolver] - Resolver to resolve the issuer DID (optional) | |||
| * @property {Boolean} [unsignedPresentation] - Whether to verify the proof or not | |||
| * @property {Boolean} [compactProof] - Whether to compact the JSON-LD or not. | |||
| * @property {Boolean} [forceRevocationCheck] - Whether to force revocation check or not. | |||
There was a problem hiding this comment.
We removed this in favour of skipRevocationCheck. Another missing option is skipSchemaCheck. See here for details. Can you please add those docs here? Thanks
There was a problem hiding this comment.
will spin off an issue and make a separate PR when have a bit of spare time - #372
lovesh
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.