-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #300
Update README.md #300
Conversation
Updating the readme to match the knowledgebase.
|
||
Dock Mobile SDK supports devices that have Android 8.1 or higher and iOS 11 or higher. | ||
|
||
Using [polkadot-js](https://polkadot.js.org/) libraries in React Native is a challenge, due to the lack of WebAssembly support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment feel incomplete. I was expecting a follow-up sentence explaining how we get around that limitation by using a WebView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the comments that we had in our previous wallet SDK documents. Feel free to add missing comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-parkhill I have moved the sentences around to address your comments, but feel free to change. The goal is to have something that is correct for now and get the examples synced as well and if a more extensive description is needed I can add that later.
README.md
Outdated
@@ -1,10 +1,14 @@ | |||
# Dock Wallet SDK | |||
|
|||
Using [polkadot-js](https://polkadot.js.org/) libraries in React Native is a challenge, due to a lack of WebAssembly support. | |||
The [Wallet SDK](https://github.com/docknetwork/react-native-sdk) enables you to build a Verifiable Credentials wallet inside your app and allows your users to receive, store, and manage their DOCK tokens too. This was built for native applications with added support for Polkadot-JS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are we trying to say with the statement, This was built for native applications...
? In the mobile world a native application is usually written in Swift or Kotlin depending on the platform.
Updating the readme to match the knowledgebase.