Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug where account backup warning remains on after backing up #170

Merged
merged 4 commits into from
Nov 2, 2023
Merged

fix: bug where account backup warning remains on after backing up #170

merged 4 commits into from
Nov 2, 2023

Conversation

Jayteekay
Copy link
Contributor

@Jayteekay Jayteekay commented Oct 16, 2023 •
edited by jira bot
Loading

Proposed changes

mike-parkhill
mike-parkhill reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@mike-parkhill mike-parkhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@Jayteekay
Copy link
Contributor Author

tests?

We have a test for this now

@maycon-mello
Copy link
Collaborator

looks like linting is failing

@Jayteekay Jayteekay merged commit cc8137e into master Nov 2, 2023
1 check passed
@Jayteekay Jayteekay deleted the fix/account-backup-warning branch November 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-parkhill mike-parkhill mike-parkhill approved these changes

@maycon-mello maycon-mello Awaiting requested review from maycon-mello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jayteekay @maycon-mello @mike-parkhill