Merge pull request #25 from docknetwork/fix/name-as-object

Fix name displayed as [object Object] depending on data
docknetwork · Jan 10, 2023 · 1e1979f · 1e1979f
2 parents 93dcf1c + bfebb22
commit 1e1979f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@docknetwork/prettyvc",
   "description": "Render pretty verifiable credentials",
-  "version": "1.3.12",
+  "version": "1.3.13",
   "main": "lib/index.js",
   "license": "MIT",
   "repository": {

diff --git a/src/index.js b/src/index.js
@@ -175,7 +175,9 @@ function extractNameFields(s) {
 
 function getSubjectName({ credentialSubject }, didMap) {
   const subjects = Array.isArray(credentialSubject) ? credentialSubject : [credentialSubject];
-  return subjects.map((s) => s && mapDIDIfKnown(getObjectName(s, extractNameFields)), didMap).join(' & ');
+  return subjects.map((s) => s && mapDIDIfKnown(getObjectName(s, extractNameFields)), didMap)
+    .filter((s) => typeof s === 'string')
+    .join(' & ');
 }
 
 function getSubjectDocuments({ credentialSubject }) {

diff --git a/src/templates/credential.js b/src/templates/credential.js
@@ -23,7 +23,11 @@ export default function TemplateCredential({
         <h3 class="prettyVC-diploma-subtitle">
           ${sanitize(subjectName)}
         </h3>
-      ` : ''}
+      ` : `
+        <p class="prettyVC-diploma-subtext">
+          has issued a <strong>${sanitize(title)}</strong>
+        </p>
+      `}
 
       ${attributes.length ? `
         <br />