Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#11 Bank onboarding workflow with Test credentials #11

Merged
merged 59 commits into from
Feb 22, 2024

Conversation

dhipgraby
Copy link
Contributor

Description

This pull request addresses several fixes and improvements across various features:

Fixes & Improvements:

  • Helper box

    • Retains the DID in storage using Zustand.
  • Improved create bank account onboarding page:

    • Implements formulary with Zod validation.
    • Utilizes mock images for Government Credentials.
  • Updated demo main page with organizations and links:

    • Changes landing page to Organizations page, now displaying all organizations with links to the test page.
  • Using Verification templates:

    • Integrates verification templates from Cert ecosystem.
  • Issuing credentials on Bank account created success:

    • Implements Biometric, Bank Account, Credit score VC.

Testing:

  • Replace the .env file with your own keys.
  • Add to .env NEXT_PUBLIC_SERVER_URL= http://localhost:3000.
  • Run with yarn dev or npm run dev.

Steps to Test:

  1. From the landing Organizations page, open Quotient to create a new bank account, filling out the form.
  2. Although most of the data is mocked, it undergoes validation for each field.
  3. Upon submission, the form will display a success page indicating that credentials have been issued.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dock-bank-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:08pm

@cykoder
Copy link
Member

cykoder commented Feb 7, 2024

pages/org/quotient.js Outdated Show resolved Hide resolved
utils/constants.js Outdated Show resolved Hide resolved
@dhipgraby dhipgraby requested review from cykoder and gasher February 14, 2024 13:09
Added dev branch into format.check.yaml as suggested @gasher
@gasher
Copy link
Collaborator

gasher commented Feb 14, 2024

The format-check is not running because the dev branch is not configured in .github/workflows/format-check.yaml. @dhipgraby Can you please add that branch so the check will run?

Added the branch for yaml file. PR awaiting.

I merged that PR but I think you'll need to merge the main branch into dev and then sync dev with this one in order for that action to run

@gasher
Copy link
Collaborator

gasher commented Feb 15, 2024

@dhipgraby I'm good with this PR I will approve it after you fix the format-check action. Most of the issues should be fixable with npm run format

_credentials/forsur.js Outdated Show resolved Hide resolved
@Dadogg80
Copy link
Contributor

@gasher, the format-check is now passing, and all suggested comments have been fixed. Can we get this PR approved and merged asap?

@Dadogg80 Dadogg80 requested a review from gasher February 19, 2024 21:41
pages/_app.js Outdated Show resolved Hide resolved
@gasher
Copy link
Collaborator

gasher commented Feb 20, 2024

@gasher, the format-check is now passing, and all suggested comments have been fixed. Can we get this PR approved and merged asap?

@Dadogg80 You are right the format-check is passing now but in the commit [fix: failing format-check](https://github.com/docknetwork/dock-bank-demo/pull/11/commits/9b8f09ad5ea9bd5cf35de3778db9b730a97c6b2a) you added a new component that I have some comments on. I'm ok with naming commits fix pr comments or fix check since all the commits will get squashed and the naming will be lost, but only when this is the only thing that commit is doing. You added a new component in that commit which might have been missed. After you resolve my comments, if there are no new changes added I will approve the PR

@Dadogg80
Copy link
Contributor

Dadogg80 commented Feb 20, 2024

@gasher, the format-check is now passing, and all suggested comments have been fixed. Can we get this PR approved and merged asap?

@Dadogg80 You are right the format-check is passing now but in the commit [fix: failing format-check](https://github.com/docknetwork/dock-bank-demo/pull/11/commits/9b8f09ad5ea9bd5cf35de3778db9b730a97c6b2a) you added a new component that I have some comments on. I'm ok with naming commits fix pr comments or fix check since all the commits will get squashed and the naming will be lost, but only when this is the only thing that commit is doing. You added a new component in that commit which might have been missed. After you resolve my comments, if there are no new changes added I will approve the PR

@gasher Nice, I have commented and suggested committing the changes you addressed. Please review and commit.

@gasher
Copy link
Collaborator

gasher commented Feb 20, 2024

@gasher, the format-check is now passing, and all suggested comments have been fixed. Can we get this PR approved and merged asap?

@Dadogg80 You are right the format-check is passing now but in the commit [fix: failing format-check](https://github.com/docknetwork/dock-bank-demo/pull/11/commits/9b8f09ad5ea9bd5cf35de3778db9b730a97c6b2a) you added a new component that I have some comments on. I'm ok with naming commits fix pr comments or fix check since all the commits will get squashed and the naming will be lost, but only when this is the only thing that commit is doing. You added a new component in that commit which might have been missed. After you resolve my comments, if there are no new changes added I will approve the PR

@gasher Nice, I have commented and suggested committing the changes you addressed. Please review and commit.

@Dadogg80 I answered most of the questions. However, I don't really like how we are using the suggested changes approach mostly because it will produce untested code that can result in errors (you can check previous uses of this feature in this PR to see how we could have had an undefined function called). So, please check my answers and fix the issues where needed in a commit

@mike-parkhill mike-parkhill merged commit a26ef8f into dev Feb 22, 2024
3 checks passed
@mike-parkhill mike-parkhill deleted the bank-onboarding-workflow branch February 22, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants