Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo-2901 #43

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# By using this stage, it provides a consistent base for both
# the dev and prod versions of the image.
###########################################################
FROM node:22-slim AS base
FROM node:23-slim AS base

# Setup a non-root user to run the app
WORKDIR /usr/local/app
Expand All @@ -23,9 +23,9 @@ COPY --chown=appuser:appuser package.json package-lock.json ./
# and automatically restart the app.
###########################################################
FROM base AS dev
ENV NODE_ENV=development
ENV NODE_ENV development
RUN npm install
CMD ["yarn", "dev-container"]
CMD ["npm", "run", "dev-container"]


###########################################################
Expand All @@ -35,10 +35,10 @@ CMD ["yarn", "dev-container"]
# installs only the production dependencies.
###########################################################
FROM base AS final
ENV NODE_ENV=production
ENV NODE_ENV production
RUN npm ci --production --ignore-scripts && npm cache clean --force
COPY ./src ./src

EXPOSE 3000

CMD [ "node", "src/index.js" ]
CMD node src/index.js
4 changes: 2 additions & 2 deletions gha.env
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
DOCKERHUB_NAMESPACE=dockerdevrel
DOCKERHUB_NAMESPACE=demonstrationorg
IMAGE_NAME=catalog-service-node
DBC_BUILDER_NAME=dockerdevrel/demo-builder
DBC_BUILDER_NAME=demonstrationorg/default
# You will also need the following secrets in the repository:
# DOCKERHUB_USERNAME
# DOCKERHUB_TOKEN
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"@aws-sdk/client-s3": "^3.651.1",
"dotenv": "^16.4.5",
"express": "^4.21.1",
"express": "4.21.2",
"kafkajs": "^2.2.4",
"multer": "^1.4.5-lts.1",
"node-fetch": "v2",
Expand Down
1 change: 0 additions & 1 deletion src/services/ProductService.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ async function createProduct(product) {
action: "product_created",
id: newProductId,
name: product.name,
upc: product.upc,
price: product.price,
});

Expand Down