Skip to content

added troubleshooting info about shared drives/files and volume mounting #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

added troubleshooting info about shared drives/files and volume mounting #587

merged 1 commit into from
Nov 16, 2016

Conversation

londoncalling
Copy link
Contributor

Proposed changes

Added information to several topics about the need for shared drives or file sharing in some cases per user feedback.

Related issue

#477

Please take a look

@ubershmekel, @dnephin , @ManoMarks , @nathanleclaire , @mstanleyjones

Signed-off-by: Victoria Bialas [email protected]

@nathanleclaire
Copy link
Contributor

Looks great (and long overdue!), my only piece of feedback is that on Windows the mount is usually C:\Users, and to be cautious in pieces which are cross-platform (e.g., the Compose getting started) to mention C:\Users as well as /Users, since there's no /Users on Windows.

@johndmulhausen
Copy link

johndmulhausen commented Nov 16, 2016

Deploy preview ready!

Built with commit 1249d35

https://deploy-preview-587--docker-docs.netlify.com

@ManoMarks
Copy link
Contributor

LGTM

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, otherwise looks good

get runtime errors indicating an application file is not found, a volume mount
is denied, or a service cannot start, try enabling file or drive sharing. Volume
mounting requires shared drives for projects that live outside of `C:\Users`
(Windows) or `/Users` (Linux, Mac), and is required for _any_ project on Docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for Linux, just for Mac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks @dnephin

@nathanleclaire
Copy link
Contributor

LGTM

added more changes

updated per Nathan's comments on properly documenting directories formats for all platforms

incorporated Daniel's review comments, and added a clarification re: users' dir

copyedits

Signed-off-by: Victoria Bialas <[email protected]>
@londoncalling londoncalling merged commit 6985576 into docker:master Nov 16, 2016
@londoncalling londoncalling deleted the compose-issue#477 branch November 16, 2016 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants