Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add //go:build directives to prevent downgrading to go1.16 language #5803

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

thaJeztah
Copy link
Member

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.29%. Comparing base (c962084) to head (2815d23).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   59.26%   59.29%   +0.02%     
==========================================
  Files         353      353              
  Lines       29540    29540              
==========================================
+ Hits        17508    17516       +8     
+ Misses      11052    11043       -9     
- Partials      980      981       +1     

@thaJeztah
Copy link
Member Author

tested with #4723 and looks OK

@thaJeztah thaJeztah added status/2-code-review kind/bugfix PR's that fix bugs area/go-sdk Changes affecting the Go SDK labels Feb 6, 2025
@thaJeztah thaJeztah merged commit bf65a46 into docker:master Feb 6, 2025
104 checks passed
@thaJeztah thaJeztah deleted the build_tags branch February 6, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants