cli-plugins/manager: IsNotFound: don't depend on causer interface #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5794 +/- ##
==========================================
- Coverage 59.44% 59.17% -0.27%
==========================================
Files 347 353 +6
Lines 29394 29472 +78
==========================================
- Hits 17472 17440 -32
- Misses 10950 11059 +109
- Partials 972 973 +1 |
Benehiko
reviewed
Feb 5, 2025
| err = e.Cause() | ||
| var e *pluginError | ||
| if errors.As(err, &e) { | ||
| err = e.Unwrap() |
There was a problem hiding this comment.
Would you be able to add more context to the commit on why this needs to change?
The error could also be wrapped multiple times before it's a notFound type. Are we sure we never wrap the error more than once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)