Add Alpine 3.19 variant #1471
Merged
Add Alpine 3.19 variant #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
tianon
reviewed
Dec 8, 2023
jnoordsij
force-pushed
the
add-alpine-3.19
branch
from
ede6bc8 to
d2b33db
Compare
The PR/change mentioned was effectively reversed by docker-library#786, after Alpine decided to move back from libressl to openssl, hence rendering this comment obsolete and possibly confusing.
jnoordsij
force-pushed
the
add-alpine-3.19
branch
from
d2b33db to
c3c7f06
Compare
|
@tianon thanks for checking this! I've applied your suggestion and rebased to account for the RC variants added on |
|
As always, thank you for the change and for sticking to it! ❤️ |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 9, 2023
Changes: - docker-library/php@1375ac82: Merge pull request docker-library/php#1471 from jnoordsij/add-alpine-3.19 - docker-library/php@c3c7f06f: Re-alphabetize runtime deps for Alpine - docker-library/php@da370e19: Drop comment about libressl package - docker-library/php@db5c8e5f: Update templates to add Alpine 3.19 and drop 3.17 - docker-library/php@10a6745d: Add Alpine 3.19 and drop 3.17 to versions.sh
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 11, 2023
Changes: - docker-library/php@95a88177: Merge pull request docker-library/php#1473 from infosiftr/socks - docker-library/php@f8c3dc9a: Fix permissions on $APACHE_RUN_DIR/socks in Debian Bookworm+ - docker-library/php@1375ac82: Merge pull request docker-library/php#1471 from jnoordsij/add-alpine-3.19 - docker-library/php@c3c7f06f: Re-alphabetize runtime deps for Alpine - docker-library/php@da370e19: Drop comment about libressl package - docker-library/php@db5c8e5f: Update templates to add Alpine 3.19 and drop 3.17 - docker-library/php@10a6745d: Add Alpine 3.19 and drop 3.17 to versions.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variant for Alpine 3.19 and drops the 3.17 variant at the same time.
See also https://alpinelinux.org/posts/Alpine-3.19.0-released.html.
As a little bonus, I also removed an outdated comment relating to libressl found when checking things for the discussion on #1463. The PR/change mentioned was effectively reversed by #786, after Alpine decided to move back from libressl to openssl,
hence rendering this comment obsolete and possibly confusing.
Note: the Alpine 3.19 base Docker image is yet to appear here, so automated checks will fail up till then; see also docker-library/official-images#15852.Edit: the Alpine 3.19 base images are now available, so this is now ready for a retrigger of the workflow!