-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for registrant APIs #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
enhancement
label
Aug 22, 2023
ghost
self-assigned this
Aug 22, 2023
DXTimer
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the create registrant change endpoint has been added please add all 5 endpoints for the registrant change API: list, check, create, show, delete.
Tests are missing.
The code should be moved out of the registrar.ts
file into its own file.
ghost
force-pushed
the
feature/create-registrant-change
branch
from
August 23, 2023 01:07
e6257a7
to
fd64f0b
Compare
ghost
changed the title
Add support to create a registrant change
Add support for registrant APIs
Aug 23, 2023
ghost
marked this pull request as ready for review
August 23, 2023 07:03
DXTimer
approved these changes
Aug 28, 2023
ghost
deleted the
feature/create-registrant-change
branch
August 29, 2023 13:11
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 5 new endpoints that are part of the domain contact management API that was introduced in dnsimple/dnsimple-developer#501.
The following endpoints have been added:
/{account}/registrar/registrant_changes
/{account}/registrar/registrant_changes
/{account}/registrar/registrant_changes/check
/{account}/registrar/registrant_changes/{registrantchange}
/{account}/registrar/registrant_changes/{registrantchange}
Belongs to https://github.com/dnsimple/dnsimple-business/issues/1729