Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EmailForward fields #254

Merged
merged 5 commits into from
May 27, 2024
Merged

Update EmailForward fields #254

merged 5 commits into from
May 27, 2024

Conversation

ggalmazor
Copy link
Contributor

See dnsimple/dnsimple-developer#315 for reference

In this PR:

  • Add alias_email and destination_email fields to EmailForward

@ggalmazor ggalmazor self-assigned this May 17, 2024
@ggalmazor ggalmazor mentioned this pull request May 17, 2024
Closed
juankuquintana
juankuquintana approved these changes May 24, 2024
View reviewed changes
test/fixtures.http/listEmailForwards/success.http
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add an extra line at the end here 😅

@ggalmazor ggalmazor merged commit 86ee918 into main May 27, 2024
19 checks passed
@ggalmazor ggalmazor deleted the change/update_email_forward branch May 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juankuquintana juankuquintana juankuquintana approved these changes

@jacegu jacegu jacegu approved these changes

Assignees

@ggalmazor ggalmazor

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggalmazor @jacegu @juankuquintana