fix: Name of team plan

[IchordeDionysos]

I did leave the enum value for the Subscription as it was...
Not sure what the current status is here:

dnsimple-developer/content/v2/openapi.yml

Line 5050 in 3124e94

- Professional Yearly

I actually also wasn't sure what to do with those dnsimple-professional plan ids.

[sbastn]

Thank you, @IchordeDionysos, for submitting these changes. Keeping the Enum values as they are makes sense, especially since we still have customers subscribed to the Professional plan (now considered legacy).

@san983, everything looks good on my end. I do have a question about the fixtures—are they purely for illustrative purposes, or do we have tests or code that depend on the specific values defined in them?

[sbastn]

Approving, pending @san983's review

[san983]

@san983, everything looks good on my end. I do have a question about the fixtures—are they purely for illustrative purposes, or do we have tests or code that depend on the specific values defined in them?

LGTM too. AFAIS this is just illustrative. But you'd have to double check with anyone from the app team.

[sbastn]

@jacegu, I tagged you for a review to make sure the changes to the fixtures are OK and won't cause any issues if there’s code or tests relying on them (which I don't think we have, but I'm not 100% sure). Thanks!

[jacegu]

@IchordeDionysos thanks for submitting these changes.

As @sbastn mentioned, this is mostly informational. I have suggested a couple changes to your diff:

• Always referring to the Teams plan as Teams (we never refer to it in singular).
• Using teams-v1-monthly as the plan identifier, as we don't really have a dnsimple-teams plan.

[IchordeDionysos]

@jacegu I applied your suggestions