Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Email from/to as deprecated #314

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Mark Email from/to as deprecated #314

merged 3 commits into from
Jan 25, 2021

Conversation

weppos
Copy link
Member

@weppos weppos commented Jan 25, 2021 •
edited
Loading

These fields has been replaced by alias_email, destination_email in response and alias_name, destination_email in request payload to better reflect the nature of the value and avoid ambiguity with same field holding different formats.

The API will continue to support and return both for now.

@weppos weppos added the task One or more no-coding actions to execute for this project. label Jan 25, 2021
@weppos weppos self-assigned this Jan 25, 2021
@weppos
Copy link
Member Author

weppos commented Jan 25, 2021

Regenerated fixtures:

bin/download_fixture.sh XXX POST https://api.dnsimple.com/v2/5623/domains/dnsimple.xyz/email_forwards '{"alias_name":"example","destination_email":"[email protected]"}' > fixtures/v2/api/createEmailForward/created.http
bin/download_fixture.sh XXX GET https://api.dnsimple.com/v2/5623/domains/dnsimple.xyz/email_forwards/41872 > fixtures/v2/api/getEmailForward/success.http
bin/download_fixture.sh XXX DELETE https://api.dnsimple.com/v2/5623/domains/dnsimple.xyz/email_forwards/41872 > fixtures/v2/api/deleteEmailForward/success.http

@weppos weppos mentioned this pull request Jan 25, 2021
Closed
@weppos weppos requested a review from duduribeiro January 25, 2021 14:38
duduribeiro
duduribeiro approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! 💯

@weppos weppos merged commit 42a6cdb into master Jan 25, 2021
@weppos weppos deleted the email-forward-changes branch January 25, 2021 18:30
@weppos weppos added documentation Updates on the documentation and support content. and removed change-api labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duduribeiro duduribeiro duduribeiro approved these changes

Assignees

@weppos weppos

Labels
documentation Updates on the documentation and support content. task One or more no-coding actions to execute for this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weppos @duduribeiro