Implemented core support for portal styles #5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
reviewed
Nov 2, 2023
GerardSmit
reviewed
Nov 9, 2023
Started implementation of portal styles. This is incomplete and a work in progress for now...
We may change our minds on these after we get the new default.css in place and the new theme but this should roughly match the current default.css values..
david-poindexter
approved these changes
Dec 9, 2023
|
Ok, I think this is good to merge now, I started work on the actual management module which I would like to submit a different PR for to make it easier to review than a huge PR and also makes this available in DNN for the theme development. |
bdukes
reviewed
Dec 11, 2023
DNN Platform/DotNetNuke.Abstractions/Portals/IPortalSettings.cs
Outdated
Show resolved
Hide resolved
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Dec 15, 2023
This is still a work in progress and when dnnsoftware#5851 will be merged, this PR will become way easier to review
valadas
changed the title
bdukes
approved these changes
Dec 16, 2023
|
Awesome, I'll merge this to make #5884 easier to review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of portal styles for the core level support.
This is complete but the overall support, in next PRs I'll submit a module to manage those settings and we can then consume those css values in dnn-elements, resource-manger, new theme, etc.