New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Button에서 Icon 관련 props 분리 #211

Merged

jhsung23 merged 1 commit into main from refactor/button

Apr 3, 2024

Member

jhsung23 commented Apr 2, 2024

✨ 작업 내용

Button 컴포넌트에서 Icon 관련 props를 제거하고 Icon 컴포넌트 자체를 받아 렌더링하도록 변경

📚 작업 결과

🙏 기타 참고 사항

✅ PR 등록 전 확인 후 체크해 주세요! (x 표시 해 주세요.)

Assignees를 지정했습니다. (해당 PR 작업한 사람을 태그해 주세요)
Labels, Milestone을 등록했습니다.
Development에 PR 내용과 연결된 Issue를 등록했습니다.


          ♻️ Button에서 Icon 관련 props 분리

07f28aa

jhsung23 added the 🔨 Refactor label

jhsung23 self-assigned this

jhsung23 requested a review from CodyMan0 as a code owner

April 2, 2024 12:48

github-actions bot commented Apr 2, 2024

🚀storybook: https://65abd47d09661c4e79c3c260-fgmmlczqml.chromatic.com/

CodyMan0 approved these changes

View reviewed changes

Collaborator

CodyMan0 left a comment

확인했습니다!! 많은 곳에서 사용되는 버튼이라 수정하기 어려웠을텐데 더욱 좋은 구조인 것 같아요!

jhsung23 merged commit c83b205 into main

4 checks passed

jhsung23 deleted the refactor/button branch

April 3, 2024 09:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels