Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] 쿠키 value 상수 변경 #142

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[CHORE] 쿠키 value 상수 변경 #142

merged 2 commits into from
Feb 22, 2024

Conversation

jhsung23
Copy link
Member

@jhsung23 jhsung23 commented Feb 22, 2024

✨ 작업 내용

📚 작업 결과

🙏 기타 참고 사항

  • 이번 pr 머지 후 로그인 테스트 및 픽스 해야 합니다...

✅ PR 등록 전 확인 후 체크해 주세요! (x 표시 해 주세요.)

  • Assignees를 지정했습니다. (해당 PR 작업한 사람을 태그해 주세요)
  • Labels, Milestone을 등록했습니다.
  • Development에 PR 내용과 연결된 Issue를 등록했습니다.

@jhsung23 jhsung23 added the 🔨 Refactor 코드 리팩토링 label Feb 22, 2024
@jhsung23 jhsung23 self-assigned this Feb 22, 2024
Copy link

Copy link
Collaborator

@CodyMan0 CodyMan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@@ -4,6 +4,8 @@ export const isProduction = process.env.NODE_ENV === 'production';
export const env = Object.freeze({
KAKAO_AUTH_URL: `${process.env.NEXT_PUBLIC_KAKAO_AUTH_URL}`,
KAKAO_REST_API_KEY: `${process.env.NEXT_PUBLIC_KAKAO_REST_API_KEY}`,
KAKAO_LOGIN_REDIRECT_URI: `${process.env.NEXT_PUBLIC_KAKAO_LOGIN_REDIRECT_URI}`,
KAKAO_LOGIN_REDIRECT_URI: isDevelopment
? `${process.env.NEXT_PUBLIC_DEV_KAKAO_LOGIN_REDIRECT_URI}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isProd라는 util 함수를 만들어도 좋겠네요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 파일 위에 isDevelopment와 isProduction 두개다 있습니다!

ACCESS_TOKEN: 'accessToken',
REFRESH_TOKEN: 'refreshToken',
ACCESS_TOKEN: 'Access-Token',
REFRESH_TOKEN: 'Refresh-Token',
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 왜 바꾸는걸까요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

백엔드 명세 변경때문입니다!

@CodyMan0 CodyMan0 self-requested a review February 22, 2024 04:23
@jhsung23 jhsung23 merged commit 09c70ff into main Feb 22, 2024
4 checks passed
@jhsung23 jhsung23 deleted the fix/login branch February 22, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants