Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Forms): add reverse to Iterate.Array #4556

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Feb 11, 2025

Here is an example when build.

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 9:00pm

Copy link

codesandbox-ci bot commented Feb 11, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :)
When adding reverse do we have to make any changes to the animation, which I assume is made for adding items at the bottom? Or maybe no change is needed 🙏

@tujoworker
Copy link
Member Author

do we have to make any changes to the animation

No, the array animation does not know whats going on inside.

@tujoworker tujoworker force-pushed the feat/iterate-array-reverse branch from 590dc1d to 7a6e8f1 Compare February 11, 2025 20:47
@tujoworker tujoworker merged commit 0b9ba79 into main Feb 13, 2025
10 checks passed
@tujoworker tujoworker deleted the feat/iterate-array-reverse branch February 13, 2025 07:56
tujoworker pushed a commit that referenced this pull request Feb 17, 2025
## [10.64.0](v10.63.4...v10.64.0) (2025-02-17)

### ✨ Features

* **Field.Expiry:** add month and year validation ([#4571](#4571)) ([bc4fff9](bc4fff9))
* **Forms:** add `createMinimumAgeVerifier` to Field.NationalIdentityNumber ([#4542](#4542)) ([ceb8c2d](ceb8c2d))
* **Forms:** add `insertAt` to Iterate.PushContainer ([#4555](#4555)) ([6160d78](6160d78))
* **Forms:** add `reverse` to Iterate.Array ([#4556](#4556)) ([0b9ba79](0b9ba79))
* **Forms:** add Bring API connector for postal code validation and autofill city ([#4554](#4554)) ([f2ccd5d](f2ccd5d))
* **Forms:** add feature fields Field.Address.Street & Field.Address.Postal ([#4562](#4562)) ([c546009](c546009))
* **Forms:** provide `{ props }` to the second `onChange`, `onFocus` and `onBlur` event parameter ([#4550](#4550)) ([374ff0e](374ff0e)), closes [#4344](#4344)
* **Forms:** show field indicator inline without shifting content below ([#4553](#4553)) ([45347a3](45347a3))
* **icons:** add digipass_corporate, digipass_private, calendar_add, investor, goal, layout_grid, table, show_pin ([#4522](#4522)) ([c5db964](c5db964)), closes [#4527](#4527)
* **PostalCodeAndCity:** deprecate `country` in favor of `countryCode` ([#4572](#4572)) ([8d0d980](8d0d980))

### 📝 Documentation

* **InfoOverlay:** display fallback content when `undefined` ([#4580](#4580)) ([9879149](9879149))
* link to base fields from their respective value components ([#4564](#4564)) ([3d71c19](3d71c19))
* link to feature fields from their respective value components ([#4563](#4563)) ([45d0e3d](45d0e3d))
* removes duplicated docs for help prop ([#4568](#4568)) ([ae46e71](ae46e71))

### 🐛 Bug Fixes

* **DatePicker:** compare `date` and `maxDate` at same time of day so `is_valid_end_date` is `true` when `date` and `maxDate` are the same date ([#4565](#4565)) ([c52a40b](c52a40b))
* **Drawer:** ensure content on very small screen sizes doesn't get cut off ([#4567](#4567)) ([1dd405f](1dd405f))
* **ePlatform:** adjust ul list style and wrapper style (`max-width` and `padding`) ([#4552](#4552)) ([44f551e](44f551e))
* **Forms:** ensure city in PostalCodeAndCity accepts non-Norwegian characters when using other country ([#4569](#4569)) ([af1bdc8](af1bdc8))
* **Forms:** reveal error only when onChangeValidator is actually the initiator ([#4570](#4570)) ([4d962df](4d962df))
* **Name:** support spacing props ([eb6a412](eb6a412))
* **TextArea:** ResizeObserver loop completed with undelivered notifications ([#4582](#4582)) ([f2f97e3](f2f97e3))
* **Wizard.Step:** use `title` as aria-label when wrapped in `Wizard.Container` ([#4573](#4573)) ([de095e7](de095e7))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.64.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants