Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Field.Date): add built in error messaging for min and max dates #4469

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Jan 16, 2025

  • Make ´DatePickerInput´ work with both status props and internal min max date validation
  • Add range logic for useDateLimitValidationMessage hook
  • Find appropriate format for dates in error messaging
  • Add tests
  • Add example in docs
  • Move functionality Field.Date
  • Move docs over to Field.Date
  • Move tests over to Field.Date
  • fix type errors
  • make error messages more accurate
  • Remove validation export

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 0:18am

Copy link

codesandbox-ci bot commented Jan 16, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk changed the title feat(DatePicker): add built in error messaging for min and max dates (WIP) feat(Field.Date): add built in error messaging for min and max dates (WIP) Jan 22, 2025
@joakbjerk joakbjerk force-pushed the feat/datepicker-min-max-date-error-message branch from fdecfdf to 7c09b9f Compare January 22, 2025 13:13
langz added a commit that referenced this pull request Jan 29, 2025
tujoworker pushed a commit that referenced this pull request Jan 29, 2025
## [10.63.0](v10.62.4...v10.63.0) (2025-01-29)

### 📝 Documentation

* **DrawerList:** fix dead link to data prop ([#4489](#4489)) ([612634f](612634f))
* **DrawerList:** minor doc improvement ([#4490](#4490)) ([ef3a816](ef3a816))
* **Extensions:** extend description ([#4456](#4456)) ([ffa0453](ffa0453))
* **Form.MainHeading, Form.SubHeading:** add `help` property to properties tabs ([#4442](#4442)) ([2148916](2148916))
* **Forms:** improve documentation on TypeScript type handling ([#4444](#4444)) ([b7639cb](b7639cb)), closes [#4443](#4443)
* **GlobalStatus:** add example on how to add custom icon ([#4457](#4457)) ([f434a8e](f434a8e))

### 🐛 Bug Fixes

* **Autocomplete:** does not fail when clicking show all button ([#4445](#4445)) ([744781b](744781b))
* **Autocomplete:** focus issue when no valid data ([#4458](#4458)) ([1f2bba1](1f2bba1))
* **Blockquote:** contrast font color of code as child ([#4453](#4453)) ([9dfd6b4](9dfd6b4))
* **Field.Upload:** prevent `fileHandler` to run when it is validation errors  ([#4506](#4506)) ([feb0217](feb0217))
* **Forms:** add animation support to Form.Visibility when used inside Value.SummaryList ([#4482](#4482)) ([c547f1a](c547f1a))
* **Forms:** don't open Field.SelectCountry when `defaultValue` was given ([#4477](#4477)) ([e9bc230](e9bc230))
* **Forms:** ensure `connectWithPath` type is given ([#4501](#4501)) ([64e7b41](64e7b41))
* **Forms:** ensure Field.Toggle supports iterate `{itemNo}` in label ([#4507](#4507)) ([dbbfa49](dbbfa49))
* **Forms:** ensure wizard step changes scroll so the StepIndicator is included at the top ([#4464](#4464)) ([352ad63](352ad63))
* **Forms:** provide `displayValue` and `label` to `transformData` from fields inside Iterate ([#4510](#4510)) ([f22b4c3](f22b4c3))
* **HeightAnimation:** ensure height does not lock during animation when nested ([#4493](#4493)) ([93974b5](93974b5))
* **InputMasked:** should work without any properties ([#4446](#4446)) ([2efc623](2efc623))
* refactor defaultProps to ES6 default parameters ([#4448](#4448)) ([34d109e](34d109e)), closes [#4447](#4447)
* **Spacing:** ensure HTML elements like h1 use always a spacing reset ([#4463](#4463)) ([5ff0126](5ff0126))
* **ToggleButton:** add type for the `size` property ([#4459](#4459)) ([33ca39c](33ca39c))

### ✨ Features

* **DatePicker:** render calendar in a react portal ([#4347](#4347)) ([e5de516](e5de516))
* **Forms:** add `connectWithItemPath` to `onBlurValidator` and `onChangeValidator` to be used within Iterate ([#4518](#4518)) ([321550f](321550f))
* **Forms:** add `itemPath` property support to `Iterate.Array` ([#4479](#4479)) ([0cc8ff6](0cc8ff6)), closes [#4417](#4417)
* **Forms:** add `itemPath` property support to `Iterate.PushButton` and `Iterate.PushContainer` ([#4499](#4499)) ([673d55c](673d55c)), closes [#4417](#4417)
* **Forms:** add `Iterate.Visibility` to be used within `Iterate.Array` (relative paths) ([#4502](#4502)) ([68e96f8](68e96f8))
* **Forms:** add `transformSelection` to Field.Selection ([#4481](#4481)) ([430a373](430a373))
* **Forms:** add support for `required` property to `Iterate.Array` ([#4470](#4470)) ([ef6485b](ef6485b))
* **Forms:** add support for `required` property to Iterate.PushContainer ([#4467](#4467)) ([28479bc](28479bc))
* **Forms:** add support for arrays with errors for `onChangeValidator` and `onBlurValidator` ([#4511](#4511)) ([2fe99aa](2fe99aa)), closes [#4469](#4469)
* **Forms:** add support for conditional function based `info`, `warning` and `error` props to all `Field.*` components ([#4421](#4421)) ([ad13e23](ad13e23))
* **Forms:** add support for inline `style` to `Field.Option` when used inside `Field.Selection` ([#4515](#4515)) ([3801d1e](3801d1e))
* **Forms:** deprecate `continuousValidation` in favor of `validateContinuously` ([#4441](#4441)) ([b6c3dad](b6c3dad))
* **Forms:** during submit, show field errors inside `Iterate.PushContainer` when `bubbleValidation` is true ([#4471](#4471)) ([95f8d76](95f8d76))
* **Forms:** ensure Form.Iterate and Form.Section containers close when cancel button is pressed ([#4494](#4494)) ([f25f44a](f25f44a))
* **Forms:** fix inactive `Iterate.PushContainer` blocking Wizard navigation when `bubbleValidation` is true ([#4473](#4473)) ([fa881d5](fa881d5)), closes [#4460](#4460)
* **Forms:** provide the internal array as a third parameter to the callback function’s children in `Iterate.Array` ([#4466](#4466)) ([938f3c8](938f3c8))
* **Pagination:** add `barSpace` prop to set spacing only on the bar ([#4500](#4500)) ([ab77e62](ab77e62))
@joakbjerk joakbjerk force-pushed the feat/datepicker-min-max-date-error-message branch from ec41888 to d45668a Compare February 7, 2025 09:49
@joakbjerk joakbjerk changed the title feat(Field.Date): add built in error messaging for min and max dates (WIP) feat(Field.Date): add built in error messaging for min and max dates Feb 7, 2025
@joakbjerk joakbjerk requested review from tujoworker and langz and removed request for tujoworker February 7, 2025 14:18
@joakbjerk joakbjerk marked this pull request as ready for review February 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants