Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Upload): adds property displayFileExtensionText to hide file extension text #4150

Closed
wants to merge 2 commits into from
Closed

feat(Upload): adds property displayFileExtensionText to hide file extension text #4150

wants to merge 2 commits into from

Conversation

langz
Copy link
Contributor

@langz langz commented Oct 18, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 1:45pm

@langz langz requested a review from tujoworker October 18, 2024 11:06
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 18, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz requested a review from joakbjerk October 20, 2024 06:07
@joakbjerk
Copy link
Contributor

Should the .png after the filename be hidden in this screenshot with displayFileExtensionText set to false, or am I misunderstanding, or looking at the wrong place? 😄
Screenshot 2024-10-20 at 09 38 30

@langz
Copy link
Contributor Author

langz commented Oct 20, 2024

Should the .png after the filename be hidden in this screenshot with displayFileExtensionText set to false, or am I misunderstanding, or looking at the wrong place? 😄

Screenshot 2024-10-20 at 09 38 30

It's this file extension text that will not be displayed:

image

Could of course be both?
Or maybe the naming of the prop or the docs of the prop could be better?

@joakbjerk
Copy link
Contributor

joakbjerk commented Oct 21, 2024 •
edited
Loading

Should the .png after the filename be hidden in this screenshot with displayFileExtensionText set to false, or am I misunderstanding, or looking at the wrong place? 😄
Screenshot 2024-10-20 at 09 38 30

It's this file extension text that will not be displayed:

image

Could of course be both? Or maybe the naming of the prop or the docs of the prop could be better?

Hmm, not sure how to improve the text, it makes sense when you made me aware that the file extensions are shown in the list, I just didn't know about that 😄

@langz
Copy link
Contributor Author

langz commented Oct 21, 2024

Should the .png after the filename be hidden in this screenshot with displayFileExtensionText set to false, or am I misunderstanding, or looking at the wrong place? 😄

Screenshot 2024-10-20 at 09 38 30

It's this file extension text that will not be displayed:

image

Could of course be both? Or maybe the naming of the prop or the docs of the prop could be better?

Hmm, not sure how to improve the text, it makes sense when you made me aware that the file extensions are shown in the list, I just didn't know about that 😄

I'll try to improve it🤞

@langz
Copy link
Contributor Author

langz commented Oct 21, 2024 •
edited
Loading

Turns out we don't need this now 🙏

As we'll remove it, #4156

@langz langz closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakbjerk joakbjerk joakbjerk approved these changes

@tujoworker tujoworker Awaiting requested review from tujoworker

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langz @joakbjerk