Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DrawerList): make for a more automated internal state managment of selection (WIP) #3767

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore(DrawerList): make for a more automated internal state managment of selection (WIP) #3767

wants to merge 6 commits into from

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Jul 9, 2024 •
edited
Loading

WIP

  • Automate it
  • Make data change trigger onChange
  • Fix tests
  • Fix visual tests
  • Add Tests
  • Add Docs

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 7:29am

@joakbjerk joakbjerk requested a review from langz July 9, 2024 11:11
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 9, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk marked this pull request as draft July 9, 2024 13:01
langz
langz reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user of this component in the given scenario described in the PR description, wouldnt this only fix the problem visually? I would still have to manage my own state for the value, right?

@joakbjerk
Copy link
Contributor Author

joakbjerk commented Jul 9, 2024 •
edited
Loading

As a user of this component in the given scenario described in the PR description, wouldnt this only fix the problem visually? I would still have to manage my own state for the value, right?

Yeah I'm actually not sure, we need to verify this 🙏

@joakbjerk joakbjerk changed the title feat(DrawerList): add prop for resetting select index on data prop change chore(DrawerList): make for a more automated internal state managment of selection Jul 10, 2024
@joakbjerk joakbjerk changed the title chore(DrawerList): make for a more automated internal state managment of selection chore(DrawerList): make for a more automated internal state managment of selection (WIP) Jul 10, 2024
@joakbjerk joakbjerk force-pushed the feat/dropdown-reset-select-index-on-data-change branch from 6d799dd to 4e344cc Compare August 30, 2024 06:34
@joakbjerk joakbjerk force-pushed the feat/dropdown-reset-select-index-on-data-change branch from cc1f916 to 8effbef Compare September 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joakbjerk @langz