docs(Img): correct the docs about the role usage #3595
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
joakbjerk
approved these changes
May 23, 2024
| @@ -13,12 +13,12 @@ import { | |||
|
|
|||
| The image element associated with the class `dnb-img` does not have much opinionated styling. It exists more to have a future possibility to optimize and add features. | |||
|
|
|||
| As of now, the React image "element" (Img) does provide a `figure` element with the `role="img"` and an `img` tag inside. This is mainly to support the [Skeleton](/uilib/components/skeleton) provider. | |||
| The React image "element" (Img) does provide a `figure` element with an `img` element inside. This is mainly to support a `caption` text and a [Skeleton](/uilib/components/skeleton). | |||
There was a problem hiding this comment.
Suggested change
| The React image "element" (Img) does provide a `figure` element with an `img` element inside. This is mainly to support a `caption` text and a [Skeleton](/uilib/components/skeleton). | |
| The React image "element" (Img) provides a `figure` element with an `img` element inside. This is mainly to support a `caption` text and a [Skeleton](/uilib/components/skeleton). |
Should we maybe change "The React image element" to "The Eufemia image element" or is that silly? 😅
langz
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.