fix(Forms): ensure pathUndefined on Form.Visibility does render whe…

…n value is `undefined`
dnbexperience · Feb 5, 2025 · e2a11c0 · e2a11c0
1 parent c1c6db1
commit e2a11c0
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/__tests__/useVisibility.test.tsx b/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/__tests__/useVisibility.test.tsx
@@ -103,6 +103,19 @@ describe('useVisibility', () => {
       )
       expect(result.current.check()).toBe(true)
     })
+
+    it('should return false when value exists but is "undefined"', () => {
+      const { result } = renderHook(useVisibility, {
+        wrapper: ({ children }) => (
+          <Provider data={{ isUndefined: undefined }}>{children}</Provider>
+        ),
+      })
+      expect(
+        result.current.check({
+          pathUndefined: '/isUndefined',
+        })
+      ).toBe(true)
+    })
   })
 
   describe('pathTruthy', () => {
@@ -725,6 +738,28 @@ describe('useVisibility', () => {
         )
         expect(result.current.check()).toBe(true)
       })
+
+      it('should return true when value exists but is "undefined"', () => {
+        const { result } = renderHook(
+          () =>
+            useVisibility({
+              withinIterate: true,
+              pathUndefined: '/isUndefined',
+            }),
+          {
+            wrapper: ({ children }) => (
+              <Provider
+                data={{
+                  myList: [{ isUndefined: undefined }],
+                }}
+              >
+                <Iterate.Array path="/myList">{children}</Iterate.Array>
+              </Provider>
+            ),
+          }
+        )
+        expect(result.current.check()).toBe(true)
+      })
     })
 
     describe('pathTruthy', () => {

diff --git a/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/useVisibility.tsx b/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/useVisibility.tsx
@@ -121,7 +121,9 @@ export default function useVisibility(props?: Partial<Props>) {
         pathUndefined &&
         pointer.has(data, makeLocalPath(pathUndefined))
       ) {
-        return false
+        return (
+          pointer.get(data, makeLocalPath(pathUndefined)) === undefined
+        )
       }
 
       const getValue = (path: Path) => {