fix(Forms): ensure pathUndefined on Form.Visibility does render whe…

…n value is `undefined`
dnbexperience · Feb 6, 2025 · a789ea2 · a789ea2
1 parent 4f99680
commit a789ea2
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 5 deletions.
diff --git a/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/__tests__/useVisibility.test.tsx b/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/__tests__/useVisibility.test.tsx
@@ -116,6 +116,19 @@ describe('useVisibility', () => {
       )
       expect(result.current.check()).toBe(true)
     })
+
+    it('should return false when value exists but is "undefined"', () => {
+      const { result } = renderHook(useVisibility, {
+        wrapper: ({ children }) => (
+          <Provider data={{ isUndefined: undefined }}>{children}</Provider>
+        ),
+      })
+      expect(
+        result.current.check({
+          pathUndefined: '/isUndefined',
+        })
+      ).toBe(true)
+    })
   })
 
   describe('pathTruthy', () => {
@@ -760,6 +773,28 @@ describe('useVisibility', () => {
         )
         expect(result.current.check()).toBe(true)
       })
+
+      it('should return true when value exists but is "undefined"', () => {
+        const { result } = renderHook(
+          () =>
+            useVisibility({
+              withinIterate: true,
+              pathUndefined: '/isUndefined',
+            }),
+          {
+            wrapper: ({ children }) => (
+              <Provider
+                data={{
+                  myList: [{ isUndefined: undefined }],
+                }}
+              >
+                <Iterate.Array path="/myList">{children}</Iterate.Array>
+              </Provider>
+            ),
+          }
+        )
+        expect(result.current.check()).toBe(true)
+      })
     })
 
     describe('pathTruthy', () => {

diff --git a/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/useVisibility.tsx b/packages/dnb-eufemia/src/extensions/forms/Form/Visibility/useVisibility.tsx
@@ -123,11 +123,8 @@ export default function useVisibility(props?: Partial<Props>) {
       if (pathDefined) {
         return getValue(makeLocalPath(pathDefined)) !== undefined
       }
-      if (
-        pathUndefined &&
-        pointer.has(data, makeLocalPath(pathUndefined))
-      ) {
-        return false
+      if (pathUndefined) {
+        return getValue(makeLocalPath(pathUndefined)) === undefined
       }
 
       if (pathTrue && getValue(makeLocalPath(pathTrue)) !== true) {
@@ -136,6 +133,7 @@ export default function useVisibility(props?: Partial<Props>) {
       if (pathFalse && getValue(makeLocalPath(pathFalse)) !== false) {
         return false
       }
+
       if (
         pathTruthy &&
         Boolean(getValue(makeLocalPath(pathTruthy))) === false
@@ -148,6 +146,7 @@ export default function useVisibility(props?: Partial<Props>) {
       ) {
         return false
       }
+
       if (inferData && !inferData(data)) {
         return false
       }