Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVEX-2466 Fix prefetch where read offset is before cache #93

Merged
merged 7 commits into from
Jan 16, 2025
Merged

DEVEX-2466 Fix prefetch where read offset is before cache #93

merged 7 commits into from
Jan 16, 2025

Conversation

kpjensen
Copy link
Member

Remove check(first >= 0), as first < 0 is valid return value as -1 indicates DATA_OUTSIDE_CACHE handled in the calling function https://github.com/dnanexus/dxfuse/blob/DEVEX-2466/prefetch.go#L952-L957.

@kpjensen kpjensen requested a review from wormsik January 15, 2025 21:25
@kpjensen kpjensen changed the title DEVEX-2466 Fix prefetch where IO offset is before cache DEVEX-2466 Fix prefetch where read offset is before cache Jan 15, 2025
wormsik
wormsik approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@wormsik wormsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kpjensen kpjensen merged commit ed23dee into master Jan 16, 2025
3 checks passed
@kpjensen kpjensen deleted the DEVEX-2466 branch January 16, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormsik wormsik wormsik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpjensen @wormsik