Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filefly editor configuration. Editable via settings module. #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

germanbisurgi
Copy link
Contributor

No description provided.

@germanbisurgi
Copy link
Contributor Author

related to dmstr/yii2-json-editor#34

@schmunk42 schmunk42 requested a review from handcode January 9, 2023 08:53
@schmunk42
Copy link
Member

@handcode LGTM, wdyt?

Copy link
Member

@handcode handcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should tag https://github.com/dmstr/yii2-json-editor and change constraint here to be sure this will have any effect, shouldn't we?

@schmunk42
Copy link
Member

LGTM

We should tag https://github.com/dmstr/yii2-json-editor and change constraint here to be sure this will have any effect, shouldn't we?

The latest tag for yii2-json-editor is 1.4.2 - here are the latest changes:
dmstr/yii2-json-editor@1.4.2...master
This would be a 1.4.3 or 1.5.0?

CC: @eluhr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants