Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminLTE 3 implementation (without gii) #193

Merged
merged 10 commits into from
Mar 9, 2020
Merged

AdminLTE 3 implementation (without gii) #193

merged 10 commits into from
Mar 9, 2020

Conversation

Tarinu
Copy link
Contributor

@Tarinu Tarinu commented Feb 29, 2020

This introduces some BC changes:

  • Namespace got changed to dmstr\adminlte since dmstr\widgets was being overwritten by the dmstr\yii2-db package in testing environment. If there's a better solution for this, then I can change it back.
  • iconClassPrefix in Menu widget was split into 2. FontAwsome 5 introduced different icon types (far, fas etc), so i thought it would be easier to be able to just change the type separately. The default type is fas (solid)
    It's possible to change the type with ['label' => 'Foo', 'iconType' => 'far']
  • Header is just ['label' => 'Foo', 'header' => true] instead of ['label' => 'Foo', 'options' => ['class' => 'header']]
  • Label is now badge and is set with the badge option ['label' => 'Foo', 'badge' => '<span class="badge badge-info right">123</span>']
  • Then there's obviously the AdminLTE changes themselves. Like using bootstrap 4 instead of 3 etc

I left the Gii part out since I'm not really that familiar with how it's working.

#183

Copy link
Member

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much.

@eluhr Please have a look a this PR.

@schmunk42 schmunk42 merged commit 34c658f into dmstr:master Mar 9, 2020
@takizo
Copy link

takizo commented Nov 26, 2021

Great work. Thanks a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants