Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use precise terminology for image components #11157

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 11, 2025

From #11079 (comment):

In general, I recommend following this type of naming for the variables involved here:

  • IMAGE_REGISTRY = the place to pull the images from, like
    • (e.g. docker.io, quay.io, ghcr.io, an ECR URL)
  • IMAGE_REPO = the name of the image, called a "repository" on some registries
    • (e.g. xgb-ci.jvm, dask/dask-notebook)
  • IMAGE_TAG = ID that separates images from the same registry and repo
    • (e.g. 2024.10, main, stable)
  • IMAGE_URI = fully-qualified identifier of the form ${IMAGE_REGISTRY}/${IMAGE_REPO}:${IMAGE_TAG}
    • (e.g. quay.io/pypa/manylinux2014_aarch64:latest)

cc @jameslamb

@hcho3 hcho3 requested a review from trivialfis January 11, 2025 14:01
@hcho3 hcho3 merged commit a4ad000 into dmlc:master Jan 11, 2025
56 of 58 checks passed
@hcho3 hcho3 deleted the use_precise_terminology branch January 11, 2025 14:25
@jameslamb
Copy link
Contributor

oh cool thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants