-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Enable prefetch on windows configure script #11141
Conversation
@trivialfis I'm not sure what to do about the CMake scripts that are failing in the CI here. This PR creates a file "Makevars.win.in" from which "Makevars.win" is created, but I guess the configure script that generates "Makevars.win" will not get executed by CMake. |
Looks like apple clang internal error for the Python test. On the other hand, do we need to worry about R |
No idea about the stringi error. But besides the apple issue, there's a problem with the cmake build trying to use a fixed |
That's weird, I will look into it. |
Could you please point me to the CI failure? I couldn't find it. |
Looks like the error got solved. This was the log: However I don't see any windows cmake R job in the CI, and I'm not sure if it'd work under such a combination (windows + cmake + R + non-msvc compiler). |
I have done some tests today with Rtools43. Need some updates to get cmake+mingw+Windows working. Not sure if it worths the effort to maintain. |
ref #9810
ref #11124
This PR adds prefetching to the compilation flags on windows when supported.
Since CRAN only uses MinGW for windows builds and the msvc build here was dropped, it enables the GC builtin unconditionally, since no other compiler will be used on windows.