[pyspark] Support collective.Conf in spark #11003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbo4958
commented
Nov 19, 2024
python-package/xgboost/spark/core.py
Outdated
| @@ -257,21 +258,20 @@ class _SparkXGBParams( | |||
| "launched on the driver side; otherwise, it will be launched on the executor side.", | |||
| TypeConverters.toBoolean, | |||
| ) | |||
| tracker_host_ip = Param( | |||
| tracker = Param( | |||
There was a problem hiding this comment.
the name "tracker" is ok?
There was a problem hiding this comment.
I would probably continue to use the name coll_cfg just to be consistent. Besides, the configuration is for both the tracker and the communicators.
There was a problem hiding this comment.
sure, I changed it to collective_conf
There was a problem hiding this comment.
I know everyone has a naming preference ... if you use a new name, please modify the existing ones in Dask for consistency.
There was a problem hiding this comment.
OK, I just changed it to coll_cfg to be compatible with dask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #10983