Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jvm-packages] update scala style configuration #10836

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[jvm-packages] update scala style configuration #10836

wants to merge 1 commit into from
+112 −37

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Sep 23, 2024

No description provided.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 23, 2024

Hi @eordentlich, @trivialfis, @hcho3, Could you help review this PR? Thx.

trivialfis
trivialfis reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests for both 2.12 and 2.13 on the CI?

jvm-packages/scalastyle-config.xml
<parameter name="illegalImports"><![CDATA[scala.collection.Seq,scala.collection.IndexedSeq]]></parameter>
</parameters>
<customMessage><![CDATA[
Don't import scala.collection.Seq and scala.collection.IndexedSeq as it may bring some problems with cross-build between Scala 2.12 and 2.13.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Don't import scala.collection.Seq and scala.collection.IndexedSeq as it may bring some problems with cross-build between Scala 2.12 and 2.13.
Don't import scala.collection.Seq and scala.collection.IndexedSeq as it may cause issues with cross-build between Scala 2.12 and 2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbo4958 @trivialfis