Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading error when feature names are missing during inference #10814

Merged

Conversation

shlomota
Copy link
Contributor

@shlomota shlomota commented Sep 9, 2024

No description provided.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@trivialfis
Copy link
Member

Could you please help fix the formatting check? You can run:

python ./tests/ci_build/lint_python.py --fix

the script runs isort, black, mypy, and pylint.

@shlomota shlomota force-pushed the fix_misleading_error_missing_features branch from e333be1 to f788ee5 Compare September 10, 2024 21:07
@shlomota
Copy link
Contributor Author

@trivialfis - is this better?
I see it's blocked?

@trivialfis trivialfis merged commit de00e07 into dmlc:master Sep 13, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants