[EM] Multi-level quantile sketching for GPU. #10813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps reduce memory usage when handling multiple batches.
trivialfis
changed the title
trivialfis
commented
Sep 9, 2024
| ) | ||
| predict = reg.predict(m) | ||
|
|
||
| numpy.testing.assert_allclose(predict_with_it, predict, rtol=1e6) |
There was a problem hiding this comment.
Removed since 1e6 was an error from the beginning, the result is not the same. Actually, the one with the iterator has a better result.
|
cc @rongou . |
rongou
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce memory usage when handling multiple batches. This is a variant of the CPU implementation. The basic idea is that when the stream size cannot be known in advance, we store the sketches in multiple levels, with each level growing in exponential size.
No new test since there are already multiple existing tests.