SYCL. Add dask support for distributed calculations with sycl #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Sep 13, 2024
| " managed by the distributed frameworks. use `device=cuda` or `device=gpu`" | ||
| " instead." | ||
| ) | ||
| if device != "sycl:gpu": |
There was a problem hiding this comment.
What happens if it's sycl GPU, is dask going to select the appropriate GPU?
There was a problem hiding this comment.
Yes, the appropriate GPUs would be selected
plugin/sycl/tree/hist_updater.cc
Outdated
| for (size_t i = 0; i < sync_ids.size(); i++) { | ||
| auto& this_hist = hist_[sync_ids[i]]; | ||
| const GradientPairT* psrc = reinterpret_cast<const GradientPairT*>(this_hist.DataConst()); | ||
| // std::copy(psrc, psrc + nbins, reduce_buffer.begin() + i * nbins); |
There was a problem hiding this comment.
Please remove the commented code.
|
Hi @trivialfis , |
trivialfis
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I continue adding of sycl support (#10806, #10701, etc).
This PR adds support for distributed calculations with sycl and add one simple test for basic verification.