[EM] Refactor ellpack construction. #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trivialfis
commented
Sep 8, 2024
•
trivialfis
commented
- Remove the calculation of n_symbols in the accessor.
- Pass the context into various ctors.
- Pack initialization steps into parameter list.
- Specialization for dense data to prepare for further compression.
- Remove the calculation of n_symbols in the accessor. - Pass the context into various ctors. - Specialization for dense data to prepare for further compression.
trivialfis
force-pushed
the
ext-ellpack-ctor
branch
from
81e5c0f
to
a268dd7
Compare
|
cc @rongou |
rongou
approved these changes
Sep 9, 2024
trivialfis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.