-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Stop vendoring libomp.dylib in MacOS Python wheels #10440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Update CI to build libxgboost.dylib without bundling libomp. |
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Jun 19, 2024
hcho3
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt microsoft/LightGBM#6391 to achieve the following goals:
libxgboost.dylib
no longer has dependency on hardcoded path oflibomp.dylib
. So it can be used in conjunction with any installation oflibomp.dylib
.libomp.dylib
is already present in memory, XGBoost will use that copy. This way, we can avoid myriad problems caused by having multiple incompatible versions of libomp (Segmentation fault on MacOS with libomp 12.0.0 #7039).One disadvantage of this approach is that users will now get an
OSError
if OpenMP is not present in the system. This is not too bad, since the error message already directs users to install OpenMP:xgboost/python-package/xgboost/core.py
Lines 224 to 230 in b9e5229
Before this commit (note the hard-coded path for libomp.dylib):
After this commit:
@jameslamb Thanks for inspiration!