[R] Don't cap global number of threads #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the failing CI job: Looks like the vignette builder is not installing all the packages mentioned under |
hcho3
approved these changes
Feb 14, 2024
Please help update the CI script: |
trivialfis
reviewed
Feb 18, 2024
R-package/R/xgb.config.R
Outdated
Comment on lines
10
to
11
| #' controlling the number of parallel threads that will be used, but some functionalities | ||
| #' might execute functions before this parameter can be supplied. |
There was a problem hiding this comment.
The only feature that has problems with local nthread is the model serialization, let's be more specific here to reduce confusion.
R-package/R/xgb.config.R
Outdated
Comment on lines
13
to
17
| #' In such cases, the global number of threads is taken from the configured number of OpenMP | ||
| #' (OMP) threads, which if not set, will default to the maximum number of available threads. | ||
| #' The number of OMP threads in turn can be configured through an environment variable | ||
| #' `OMP_NUM_THREADS` (which needs to be set before R is started), or alternatively, can be | ||
| #' changed in an R session through package `RhpcBLASctl`, by calling function `RhpcBLASctl::omp_set_num_threads`. |
There was a problem hiding this comment.
I think a simple note that in addition to the nthread parameter, XGBoost honors global configuration set by OMP_NUM_THREADS or RhpcBLASctl should suffice.
|
R tests are now passing. |
trivialfis
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
ref #10027
This PR removes manual capping of number of threads in XGBoost functions that take it from a global config instead of being supplied as argument.
CRAN has a requirement of not using more than 2 threads in tests and examples, so it substitutes this workaround with a manual setting of OMP threads config, which is done through a new dependency
RhpcBLASctlthat provides such functionality; and adds silent calls to it before the tests that might execute something with the global number of OMP threads, the same way it was done in LightGBM: microsoft/LightGBM#6226Note: I am not entirely sure that I added silent calls to this function that sets the OMP threads in all of the examples where it's needed.