Bugs in launcher.py #574
Closed
Bugs in launcher.py #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discovered by Michal M
szha
reviewed
Oct 21, 2019
| @@ -52,7 +52,7 @@ def main(): | |||
| (classpath, _) = subprocess.Popen('%s/bin/hadoop classpath' % hadoop_home, | |||
| stdout=subprocess.PIPE, shell=True, | |||
| env=os.environ).communicate() | |||
| for f in classpath.split(':'): | |||
| for f in classpath.decode('utf-8').split(':'): | |||
There was a problem hiding this comment.
assuming the change is for python2, could you verify it for python3 too?
There was a problem hiding this comment.
Nope, this is for python3. If the changes was not made, the wrong path will be included. I was trying to play with xgboost0.82 off hadoop/yarn. I was having a hard time getting it to run. Michal M discovered this bug and hence the proposed fix.
|
@wendycwong Can you review #564? It addresses the same bug and supports both Python 2 and 3. |
|
Closing in favor of #564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered by Michal M