Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dist] fix node/edge map for few nodes/edges #7785

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

Rhett-Ying
Copy link
Collaborator

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 6, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 6, 2024

Commit ID: a2b0f48b9aeb1c4ae4b104992e7061b6a2bad062

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 6, 2024

Commit ID: 42e39965d7d676e205fcc22ed752e1a55bd69882

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

python/dgl/distributed/partition.py Outdated Show resolved Hide resolved
python/dgl/distributed/partition.py Outdated Show resolved Hide resolved
python/dgl/distributed/partition.py Show resolved Hide resolved
python/dgl/distributed/partition.py Show resolved Hide resolved
python/dgl/distributed/partition.py Show resolved Hide resolved
python/dgl/distributed/partition.py Show resolved Hide resolved
tests/distributed/test_partition.py Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 9, 2024

Commit ID: 481a3e0b1c2fc039b078a05fd16c861ddd157dd6

Build ID: 3

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 9, 2024

Commit ID: 465c2f69c46827ec26a8cb0496faabd61b7218a9

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 9, 2024

Commit ID: 2bc8c0f5b0df1abddfb596f6687e20cf8785634b

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rhett-Ying Rhett-Ying merged commit bf125d8 into dmlc:master Sep 10, 2024
2 checks passed
@Rhett-Ying Rhett-Ying deleted the dist-partition-etype branch September 10, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dist] partition_graph crash if no etyped edges or ntyped nodes are available
3 participants