Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ES logger for bulk requests #382

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

arvchristos
Copy link
Contributor

@arvchristos arvchristos commented Aug 23, 2023

This PR is introducing bulk requests for the ES logger, introducing a new parameter called bulk-size and splits the previous url parameter in server and index.

Additionally, a new parameter (flush-interval) is introduced, to flush the ES buffer on a defined period.

@dmachard
Copy link
Owner

Many thanks for this enhancement :)
It will be nice to clear the buffer also after some time as below

case <-flushTimer.C:

@arvchristos
Copy link
Contributor Author

Many thanks for this enhancement :) It will be nice to clear the buffer also after some time as below

case <-flushTimer.C:

This is indeed a nice idea. Done :)

@dmachard
Copy link
Owner

dmachard commented Aug 27, 2023

lgtm, thanks!

@dmachard dmachard merged commit f885f04 into dmachard:main Aug 27, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants