Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix try/except in from_reference shadowing MissingDependencyException #1939

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix try/except in from_reference shadowing MissingDependencyException #1939

merged 1 commit into from
Oct 9, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Oct 9, 2024

SourceReference.from_reference masks MissingDependencyException as UnknownSourceReference.

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 768a73e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67068a5fb5974c00082cf0a5

rudolfix
rudolfix approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit 7ac2ae1 into devel Oct 9, 2024
59 of 61 checks passed
@rudolfix rudolfix deleted the fix/from_reference_rerase_deps_exception branch October 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burnash @rudolfix