Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements secret masking for auth helpers #1643

Closed
wants to merge 1 commit into from

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Jul 29, 2024

Description

Related Issues

Follow-up to #1474

Additional Context

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit e9fcc38
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66a79141cf66830008eb69ee
😎 Deploy Preview https://deploy-preview-1643--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp
Copy link
Collaborator

sh-rp commented Jul 30, 2024

I know this is not ready for review yet, but I think a better approach would be to use introspection to find the parts of a config that are secrets (they will be annotated as secrets) and then mask those. Another thing we could potentially do is to save all secrets that were retrieved from any of the providers in a list somewhere and just clean all log messages with regexes, this might be a bit slow though..

So in short: Some implementation where we do not need to take care of every individual secret in any config would be good.

@willi-mueller
Copy link
Collaborator Author

I know this is not ready for review yet, but I think a better approach would be to use introspection to find the parts of a config that are secrets (they will be annotated as secrets) and then mask those. Another thing we could potentially do is to save all secrets that were retrieved from any of the providers in a list somewhere and just clean all log messages with regexes, this might be a bit slow though..

So in short: Some implementation where we do not need to take care of every individual secret in any config would be good.

Thank you, that's helpful!

We have this PR for review where we mask the sensitive fields of known classes and config values: dlt-hub/verified-sources#542. Is this better?

@sh-rp
Copy link
Collaborator

sh-rp commented Nov 4, 2024

@sh-rp we need to make sure no secrets leak on validation and no secrets leak when calling __str__ on a ConfigurationObject.

@sh-rp
Copy link
Collaborator

sh-rp commented Nov 5, 2024

closing in favor of this implementation: #2027

@sh-rp sh-rp closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants