feat(destinations): implement destination_info property #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IlyaFaer
commented
Jul 2, 2024
|
@rudolfix, made a draft for the item 2 (you said we have to talk about it first) to see if it's close to what was requested. |
rudolfix
requested changes
Jul 10, 2024
|
@rudolfix, oh, so in Locally, all the tests are passing, except two, because I don't have credentials for them:
So, I guess, this one can be merged, and I'll move the tests into |
IlyaFaer
force-pushed
the
destination_info
branch
from
704999a
to
19c41ea
Compare
IlyaFaer
force-pushed
the
destination_info
branch
from
19c41ea
to
ce291ea
Compare
rudolfix
force-pushed
the
devel
branch
2 times, most recently
from
2ee3eab
to
e48f641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #751
Implements item 2